Fix version height computed as 0 when project path has non-canonical casing #1244

Copilot · 2025-08-10T19:04:08Z

When a project's repo-relative path case doesn't match what git records (e.g., project reports path as a/b but git records it as A/b), the managed git implementation fails to walk the tree when searching for version.json files. This results in a version height of 0 instead of the correct value.

Root Cause

The issue was in ManagedVersionFile.GetVersion() at line 164 where GetTreeEntry() uses case-sensitive matching to find directory entries. When the path casing doesn't match git's records, the tree walk fails and no version.json file is found.

Solution

This PR implements case-insensitive fallback logic for the managed git implementation:

Git Config Reading: Added ReadIgnoreCaseFromConfig() method to read core.ignorecase setting from git configuration files (both repository-specific and global)
Case-Insensitive Tree Matching: Extended GitTreeStreamingReader.FindNode() with an optional ignoreCase parameter that performs ASCII case-insensitive comparison
Fallback Logic: Modified GitRepository.GetTreeEntry() to attempt case-insensitive matching when core.ignorecase=true and the initial case-sensitive search fails

Example

// Before: This would fail if git recorded the path as "MyProject" but code used "myproject"
var versionOptions = context.VersionFile.GetVersion("myproject");  // Returns null

// After: With core.ignorecase=true, this now works correctly
var versionOptions = context.VersionFile.GetVersion("myproject");  // Returns version info

Testing

Added comprehensive unit tests covering case-sensitive, case-insensitive, and edge case scenarios
All existing tests continue to pass, confirming no regressions
The LibGit2 implementation already handles this correctly via libgit2's native case-insensitive support

Fixes #618.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

aka.ms
- Triggering command: curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED (dns block)
dotnetbuilds.azureedge.net
- Triggering command: curl --retry 20 --retry-delay 2 --connect-timeout 15 -sSL -f --create-dirs REDACTED (dns block)
- Triggering command: curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…mentation Co-authored-by: AArnott <[email protected]>

Co-authored-by: AArnott <[email protected]>

Updated [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) from 3.7.115 to 3.8.118. <details> <summary>Release notes</summary> _Sourced from [Nerdbank.GitVersioning's releases](https://github.com/dotnet/Nerdbank.GitVersioning/releases)._ ## 3.8.118 ## Fixes * Don't try to disable CA2243 warnings in the generated version info files for F# by @Numpsy in dotnet/Nerdbank.GitVersioning#1174 * Catch a more general JsonException. by @ANGEL-OF-DEV in dotnet/Nerdbank.GitVersioning#1191 * Retarget links to migrated docs by @bencemali in dotnet/Nerdbank.GitVersioning#1193 * Check MSBuild items with case insensitivity by @AArnott in dotnet/Nerdbank.GitVersioning#1213 * Fix inconsistent CLI output format for GitCommitDate by @Copilot in dotnet/Nerdbank.GitVersioning#1246 * Fix version height computed as 0 when project path has non-canonical casing by @Copilot in dotnet/Nerdbank.GitVersioning#1244 * When generating the GitCommitDate field in the AssemblyInfo for F#, d… by @Numpsy in dotnet/Nerdbank.GitVersioning#1253 * Only do Android version check on applications by @dotMorten in dotnet/Nerdbank.GitVersioning#1256 * Fix `nbgv set-version` to write to the best version.json file in scope by @AArnott in dotnet/Nerdbank.GitVersioning#1264 ## Enhancements * Add msbuild-provided prerelease identifiers by @AArnott in dotnet/Nerdbank.GitVersioning#1153 * Add support for stamping version on server.json for MCP servers with 0.0.0-placeholder replacement by @Copilot in dotnet/Nerdbank.GitVersioning#1270 and by @AArnott in dotnet/Nerdbank.GitVersioning#1271 * Add option to set / skip CloudBuildNumber by @MattKotsenas in dotnet/Nerdbank.GitVersioning#1190 * Add Central Package Management (CPM) support to nbgv install command by @Copilot in dotnet/Nerdbank.GitVersioning#1208 * Add --public-release argument to nbgv get-version command by @Copilot in dotnet/Nerdbank.GitVersioning#1245 * Invoke PrivateP2PCaching.proj fewer times by @AArnott in dotnet/Nerdbank.GitVersioning#1263 ## Other changes * Update dependency Cake.Core to v5 by @renovate[bot] in dotnet/Nerdbank.GitVersioning#1183 ## New Contributors * @ANGEL-OF-DEV made their first contribution in dotnet/Nerdbank.GitVersioning#1191 * @bencemali made their first contribution in dotnet/Nerdbank.GitVersioning#1193 * @Copilot made their first contribution in dotnet/Nerdbank.GitVersioning#1208 * @dotMorten made their first contribution in dotnet/Nerdbank.GitVersioning#1256 * @emmanuel-ferdman made their first contribution in dotnet/Nerdbank.GitVersioning#1145 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.7.115...v3.8.118 ## 3.8.106-alpha ## What's Changed ### Enhancements * Add option to set / skip CloudBuildNumber by @MattKotsenas in dotnet/Nerdbank.GitVersioning#1190 * Add Central Package Management (CPM) support to nbgv install command by @Copilot in dotnet/Nerdbank.GitVersioning#1208 * Add --public-release argument to nbgv get-version command by @Copilot in dotnet/Nerdbank.GitVersioning#1245 * Invoke PrivateP2PCaching.proj fewer times by @AArnott in dotnet/Nerdbank.GitVersioning#1263 ### Fixes * Catch a more general JsonException. by @ANGEL-OF-DEV in dotnet/Nerdbank.GitVersioning#1191 * Retarget links to migrated docs by @bencemali in dotnet/Nerdbank.GitVersioning#1193 * Check MSBuild items with case insensitivity by @AArnott in dotnet/Nerdbank.GitVersioning#1213 * Fix inconsistent CLI output format for GitCommitDate by @Copilot in dotnet/Nerdbank.GitVersioning#1246 * Fix version height computed as 0 when project path has non-canonical casing by @Copilot in dotnet/Nerdbank.GitVersioning#1244 * When generating the GitCommitDate field in the AssemblyInfo for F#, d… by @Numpsy in dotnet/Nerdbank.GitVersioning#1253 * Only do Android version check on applications by @dotMorten in dotnet/Nerdbank.GitVersioning#1256 * Fix `nbgv set-version` to write to the best version.json file in scope by @AArnott in dotnet/Nerdbank.GitVersioning#1264 ### Other changes * Update dependency Cake.Core to v5 by @renovate[bot] in dotnet/Nerdbank.GitVersioning#1183 ## New Contributors * @ANGEL-OF-DEV made their first contribution in dotnet/Nerdbank.GitVersioning#1191 * @bencemali made their first contribution in dotnet/Nerdbank.GitVersioning#1193 * @Copilot made their first contribution in dotnet/Nerdbank.GitVersioning#1208 * @dotMorten made their first contribution in dotnet/Nerdbank.GitVersioning#1256 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.8.38-alpha...v3.8.106-alpha ## 3.8.38-alpha ## Fixes * Don't try to disable CA2243 warnings in the generated version info files for F# by @Numpsy in dotnet/Nerdbank.GitVersioning#1174 ## Enhancements * Add msbuild-provided prerelease identifiers by @AArnott in dotnet/Nerdbank.GitVersioning#1153 ## New Contributors * @emmanuel-ferdman made their first contribution in dotnet/Nerdbank.GitVersioning#1145 **Full Changelog**: dotnet/Nerdbank.GitVersioning@v3.7.115...v3.8.38-alpha Commits viewable in [compare view](dotnet/Nerdbank.GitVersioning@v3.7.115...v3.8.118). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Nerdbank.GitVersioning&package-manager=nuget&previous-version=3.7.115&new-version=3.8.118)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Initial plan

211ef26

Copilot AI assigned Copilot and AArnott Aug 10, 2025

Copilot started work on behalf of AArnott August 10, 2025 19:04 View session

Copilot AI and others added 2 commits August 10, 2025 19:29

Implement case-insensitive path matching support in managed git imple…

6c348ae

…mentation Co-authored-by: AArnott <[email protected]>

Add comprehensive tests for case-insensitive path matching functionality

6fbcf6f

Co-authored-by: AArnott <[email protected]>

Copilot AI changed the title ~~[WIP] Version height computed to be 0 when project is built with path with non-canonical casing~~ Fix version height computed as 0 when project path has non-canonical casing Aug 10, 2025

Copilot AI requested a review from AArnott August 10, 2025 19:35

Copilot finished work on behalf of AArnott August 10, 2025 19:35

fix stylecop issues

9ffb036

AArnott marked this pull request as ready for review August 10, 2025 19:53

AArnott enabled auto-merge (squash) August 10, 2025 19:53

AArnott added this to the v3.8 milestone Aug 10, 2025

AArnott merged commit c273e6a into main Aug 10, 2025
12 checks passed

AArnott deleted the copilot/fix-618 branch August 10, 2025 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix version height computed as 0 when project path has non-canonical casing #1244

Fix version height computed as 0 when project path has non-canonical casing #1244

Copilot AI commented Aug 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Fix version height computed as 0 when project path has non-canonical casing #1244

Fix version height computed as 0 when project path has non-canonical casing #1244

Conversation

Copilot AI commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Solution

Example

Testing

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Aug 10, 2025 •

edited

Loading